Closed
Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
13 tasks
Aleksanaa
reviewed
Nov 8, 2025
Comment on lines
+32
to
36
| cmakeFlags = lib.optionals stdenv.hostPlatform.isStatic [ | ||
| (lib.cmakeBool "DOCTEST_WITH_TESTS" false) | ||
| ]; | ||
|
|
||
| doCheck = true; |
Member
There was a problem hiding this comment.
Suggested change
| cmakeFlags = lib.optionals stdenv.hostPlatform.isStatic [ | |
| (lib.cmakeBool "DOCTEST_WITH_TESTS" false) | |
| ]; | |
| doCheck = true; | |
| cmakeFlags = [ | |
| (lib.cmakeBool "DOCTEST_WITH_TESTS" finalAttrs.finalPackage.doCheck) | |
| ]; | |
| doCheck = !stdenv.hostPlatform.isStatic; |
Like this?
Contributor
Author
There was a problem hiding this comment.
In staging, as doctest is a mass rebuild.
nixpkgs-ci
bot
added
2.status: merge conflict
One of the examples/tests doctest tries to build involves a dynamic library, which fails with the usual linker errors on static platforms. Disable them in this case to fix the build.
alois31
force-pushed
the
push-xpoylyntomum
branch
from
6cfba04 to
7b4aed5
Compare
Contributor
Author
|
Ah, the duplicate #458967 has already been merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the examples/tests doctest tries to build involves a dynamic library, which fails with the usual linker errors on static platforms. Disable them in this case to fix the build.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.